search

strimzi / metrics-reporter

Prometheus Metrics Reporter for Apache Kafka server and client components
Apache License 2.0
5 stars 10 forks source link

Move label filtering into KafkaPrometheusReporter and out of the KafkaPrometheusCollector #38

Closed OwenCorrigan76 closed 3 months ago

OwenCorrigan76 commented 3 months ago

This PR is in response to the following issue: https://github.com/strimzi/metrics-reporter/issues/9 Moving the label filtering into the metricChange method means that filtering is done when the Reporter is initialised. It was previously done in the collect method.

OwenCorrigan76 commented 3 months ago

@mimaison Thanks for the extra pass and comments. Hopefully there's nothing missed now.