search

strimzi / metrics-reporter

Prometheus Metrics Reporter for Apache Kafka server and client components
Apache License 2.0
5 stars 10 forks source link

Separate logic for Kafka and Yammer metrics #49

Closed mimaison closed 1 month ago

mimaison commented 1 month ago

This fixes #48

This PR separates the Kafka and Yammer specific metric logic. This ensures that when usingKafkaPrometheusMetricsReporter, only classes present in kafka-clients are used. On the other hand YammerPrometheusMetricsReporter can use all dependencies present in the Kafka distribution as it's only used on the server side.

k-wall commented 1 month ago

@mimaison could you add a sentence or two to the PR description outlining at a high level how the problem is solved. It should help reviewers understand the intent.