search

strimzi / strimzi-kafka-oauth

OAuth2 support for Apache Kafka® to work with many OAuth2 authorization servers
Apache License 2.0
144 stars 89 forks source link

testsuite/docker/kerberos/config.sh:3:4: error[SC2078]: This expression is constant. Did you forget a $ somewhere? #241

Open k-wall opened 4 months ago

k-wall commented 4 months ago

https://github.com/strimzi/strimzi-kafka-oauth/blob/229daee85b096804d16e2904c8c0f1add599cc99/testsuite/docker/kerberos/config.sh#L3

Snyk flags this error, which does indeed look like a true positive.

Error: SHELLCHECK_WARNING:
testsuite/docker/kerberos/config.sh:3:4: error[SC2078]: This expression is constant. Did you forget a $ somewhere?
#    1|   #!/bin/bash
#    2|   
#    3|-> [[ "TRACE" ]] && set -x
#    4|   
#    5|   : ${REALM:=KERBEROS}
mstruk commented 4 months ago

It looks like it should be $TRACE.