search

strimzi / strimzi-kafka-operator

Apache Kafka® running on Kubernetes
https://strimzi.io/
Apache License 2.0
4.64k stars 1.26k forks source link

[DOC]: The new quotas API does not allow to set check interval #10311

Open fvaleri opened 1 week ago

fvaleri commented 1 week ago

Related problem

The default check interval is 60 seconds, which may be too much for some use cases. The only way to configure this is to use .spec.kafka.config, which is undocumented.

Suggested solution

Add checkIntervalSec to the quotas API with related documentation.

Alternatives

No response

Additional context

No response

scholzj commented 1 week ago

What does too much mean? Too small? Too big?

fvaleri commented 1 week ago

What does too much mean? Too small? Too big?

Too big.

scholzj commented 1 week ago

I guess if you make it smaller you just overload the Admin API without gaining too much.

BTW: The proposal specifically expects that Other options might be configured directly by the user in .spec.kafka.config section of the Kafka CR.

fvaleri commented 1 week ago

I guess if you make it smaller you just overload the Admin API without gaining too much.

I think it is useful to set a lower value, because a sudden and unexpected increase in the incoming bytes rate can fill up the disc in less than a minute, especially if you didn't leave room for this.

The plugin project itself sets the check interval to 5 seconds as an example in the main readme. In general, I feel this is an important configuration to expose through the API.

BTW: The proposal specifically expects that Other options might be configured directly by the user in .spec.kafka.config section of the Kafka CR.

Ok, I didn't remember that, but I don't think users read the proposal. Additionally, we have the following phrase in the changelog: the configuration of the plugin inside .spec.kafka.config is ignored and should be removed.

scholzj commented 1 week ago

I think it is useful to set a lower value, because a sudden and unexpected increase in the incoming bytes rate can fill up the disc in less than a minute, especially if you didn't leave room for this.

I think you should plan with a sufficient buffer for this rather than play with the frequency of the check.

fvaleri commented 1 week ago

I think you should plan with a sufficient buffer for this rather than play with the frequency of the check.

I agree, but we have things like test clusters, perf and load tests, so there could be valid use cases for this.

scholzj commented 4 days ago

Discussed on the community call on 10.7.2024: We should update the documentation to suggest that additional options can be configured in .spec.kafka.config.