Refactor the implementation for getting status of rebalance proposal request

tinaselenge commented 2 months ago

Type of change

Select the type of your PR

Refactoring

Description

Use /kafkacruisecontrol/user_tasks endpoint to check the status of proposal request (rebalance request in dry mode) instead of /kafkacruisecontrol/rebalance endpoint with userTaskId. This makes it more consistent with how we check the status of rebalance request.
Updated MockCruiseControl.setupCCRebalanceResponse() to set user task id to the one that matches verbose response, so that the subsequent requests to /user_tasks endpoint can return a verbose response with load optimisation.

Closes #10294

Checklist

Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md
[ ] Supply screenshots for visual changes, such as Grafana dashboards

scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

tinaselenge commented 1 month ago

@tinaselenge I left one comment and overall it seems to be ok. Anyway before merging I would love if you could rebase against the main (where now the auto-rebalancing is available). I would like to give this PR a go locally together with auto-rebalancing before approving.

@ppatierno I have rebased it to main :)

ppatierno commented 1 month ago

@tinaselenge thanks! Anyway I would like to wait for this PR https://github.com/strimzi/strimzi-kafka-operator/pull/10652 to be merged and doing another rebase, because it fixes a subtle bug in auto-rebalancing. So I would like to try your PR against the "final" auto-rebalancing. But in general your PR LGTM, just looking for the confirmation by testing it with the auto-rebalancing.

ppatierno commented 1 month ago

@tinaselenge finally https://github.com/strimzi/strimzi-kafka-operator/pull/10652 was merged. Can you rebase your PR so I can try it locally? Thanks!

tinaselenge commented 1 month ago

@ppatierno I have rebased again and addressed the review comment. Thanks

ppatierno commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

strimzi / strimzi-kafka-operator