Clean up methods in Connect and MM2 Assembly Operators - Githubissues

strimzi / strimzi-kafka-operator

Apache Kafka® running on Kubernetes

https://strimzi.io/

Apache License 2.0

4.86k stars 1.3k forks source link

Clean up methods in Connect and MM2 Assembly Operators #10640

Closed katheris closed 1 month ago

katheris commented 1 month ago

Type of change

Select the type of your PR

Refactoring

Description

Clean up methods in Connect and MM2 Assembly Operators:

Move methods to align them across the KafkaConnectAssemblyOperator, KafkaMirrorMaker2AssemblyOperator and AbstractConnectOperator
Use port field directly instead of hard coded KafkaConnectCluster.REST_API_PORT
Refactor connector reconcile methods in KafkaConnectAssemblyOperator to make it easier to follow

Checklist

Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[x] Make sure all tests pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md
[ ] Supply screenshots for visual changes, such as Grafana dashboards

scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).