strimzi / strimzi-kafka-operator

Apache Kafka® running on Kubernetes
https://strimzi.io/
Apache License 2.0
4.86k stars 1.3k forks source link

Use configuration providers instead of `envsubst` in Kafka configuration files #10656

Closed scholzj closed 1 month ago

scholzj commented 1 month ago

Type of change

Description

This PR changes how we handle various variables in the Kafka broker (or controller) configuration files. Instead of using environment variables and replacing them with envsubst, it moves to use configuration providers to have them loaded inside Kafka.

This helps us to:

The way this is implemented is that we initialize two different providers:

And we use these providers to read data from files or environment variables. The PKCS12 passwords and the OAuth secrets are passed through environment variables and rendered suing the environment variable provider. the rack ID and worker node address (used for node port listeners) are passed as a file and loaded through the file config provider. For this, the layout of the files generated by the init container was slightly modified,

Checklist

scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run upgrade

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run upgrade

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run regression

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run zookeeper-regression

scholzj commented 1 month ago

/azp run migration

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
scholzj commented 1 month ago

/azp run upgrade

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).