search

strimzi / strimzi-lab

A lab focused on deploying streaming applications on top of Strimzi
Apache License 2.0
23 stars 78 forks source link

fixed image locations in summit labs #24

Open hodrigohamalho opened 6 years ago

hodrigohamalho commented 6 years ago

Yes, I did. The images doesn't load.

Check it at: https://github.com/strimzi/strimzi-lab/blob/master/rh-summit-2018/module-01.adoc

And the other modules...

ppatierno commented 6 years ago

I know that images aren't showed in the GitHub repo but the documentation is made with the objective to be made using asciidoctor in order to build the final HTML file and not having them available directly in the repo.

ppatierno commented 6 years ago

Another thing, I don't think that we have to adapt the documentation to the new Strimzi version. This is the demo of the RH Summit 2018 where we used Strimzi 0.3.0 during the lab. We don't want to update this demo every time a new Strimzi version will come.

hodrigohamalho commented 6 years ago

I agree with you with the demo update strategy, but the documentation (broken images, etc) I think it should be always working independent of the version.

Just my 2cents.

ppatierno commented 6 years ago

I see your point but Strimzi is a fast evolving project and breaking changes happen quite easily. For this reason the summit 2018 demo should work out of box without changes. We'll hve something different in the future as you suggest with doc not related to release.