search

strimzi / strimzi-ui

Strimzi UI
Apache License 2.0
26 stars 27 forks source link

feat: add support for translation and feature flags in navigation #126

Closed JQrdan closed 3 years ago

JQrdan commented 4 years ago

Contributes to: #68

github-actions[bot] commented 4 years ago

PR Report

Bundle Sizes

View bundle sizes for 'client'
|Bundle|New Size|Original Size|Increase/Decrease|File| |---|---|---|---|---| |1.bundle.js|631.33KB|631.33KB|0%|1.bundle.js| |Strimzi UI JS Bundle|11.08KB|11.08KB|0%|main.bundle.js| ##### Overall bundle size change: 0%
View bundle sizes for 'server'
|Bundle|New Size|Original Size|Increase/Decrease|File| |---|---|---|---|---| |Strimzi UI Server JS Bundle|26.64KB|26.67KB|0%|main.js| ##### Overall bundle size change: -0.1%

Test Coverage

View test coverage
| File | Lines | Statement | Functions | Branches | | --- | --- | --- | --- | --- | | Total | 100% | 100% | 100% | 100% | | client/Bootstrap/Navigation/useRouteConfig/useRouteConfig.hook.ts | 100% | 100% | 100% | 100% | | client/Contexts/ConfigFeatureFlag/Context.tsx | 100% | 100% | 100% | 100% | | client/Contexts/ConfigFeatureFlag/FeatureFlag.view.tsx | 100% | 100% | 100% | 100% | | client/Contexts/Introspect/Introspection.ts | 100% | 100% | 100% | 100% | | client/Contexts/Logging/Context.tsx | 100% | 100% | 100% | 100% | | client/Hooks/useConfigFeatureFlag/useConfigFeatureFlag.ts | 100% | 100% | 100% | 100% | | client/Hooks/useLogger/Hook.ts | 100% | 100% | 100% | 100% | | client/Panels/Error404/Error404.tsx | 100% | 100% | 100% | 100% | | client/Panels/Home/Home.tsx | 100% | 100% | 100% | 100% | | client/Utils/sanitise/sanitise.ts | 100% | 100% | 100% | 100% | | client/Utils/window/window.ts | 100% | 100% | 100% | 100% | | File | Lines | Statement | Functions | Branches | | --- | --- | --- | --- | --- | | Total | 100% | 100% | 100% | 100% | | server/api/controller.ts | 100% | 100% | 100% | 100% | | server/api/router.ts | 100% | 100% | 100% | 100% | | server/client/controller.ts | 100% | 100% | 100% | 100% | | server/client/router.ts | 100% | 100% | 100% | 100% | | server/config/controller.ts | 100% | 100% | 100% | 100% | | server/config/router.ts | 100% | 100% | 100% | 100% | | server/core/app.ts | 100% | 100% | 100% | 100% | | server/core/modules.ts | 100% | 100% | 100% | 100% | | server/log/router.ts | 100% | 100% | 100% | 100% | | server/mockapi/data.ts | 100% | 100% | 100% | 100% | | server/mockapi/router.ts | 100% | 100% | 100% | 100% |

Triggered by commit: 26898902e404b4a4736f2fae3b106a63218bf5bc

nictownsend commented 3 years ago

Pending @nictownsend 's review, this LGTM

Sorry - clicked comment instead of approve!