strimzi / strimzi-ui

Strimzi UI
Apache License 2.0
26 stars 27 forks source link

Example of carbon / patternfly view switching #141

Open dlabaj opened 3 years ago

dlabaj commented 3 years ago

We plan to ship carbon as the default view layer. However we do need a way to switch between the patternfly view. We should add an example implementation of this to the client.

Fixes issue #127

github-actions[bot] commented 3 years ago

PR Report

Bundle Sizes

View bundle sizes for 'client'
|Bundle|New Size|Original Size|Increase/Decrease|File| |---|---|---|---|---| |447.bundle.js|177.54KB|0KB|N/A|447.bundle.js| |Strimzi UI JS Bundle|3.89KB|11.08KB|-65%|main.bundle.js| |989.bundle.js|1.73KB|0KB|N/A|989.bundle.js| ##### Overall bundle size change: -99.39%
View bundle sizes for 'server'
|Bundle|New Size|Original Size|Increase/Decrease|File| |---|---|---|---|---| |Strimzi UI Server JS Bundle|17.38KB|26.67KB|-35%|main.js| ##### Overall bundle size change: -34.82%

Test Coverage

View test coverage
| File | Lines | Statement | Functions | Branches | | --- | --- | --- | --- | --- | | Total | 100% | 100% | 100% | 100% | | client/Bootstrap/Navigation/useRouteConfig/useRouteConfig.hook.ts | 100% | 100% | 100% | 100% | | client/Contexts/ConfigFeatureFlag/Context.tsx | 100% | 100% | 100% | 100% | | client/Panels/Home/Home.carbon.tsx | 100% | 100% | 100% | 100% | | client/Panels/Home/Home.patternfly.tsx | 100% | 100% | 100% | 100% | | File | Lines | Statement | Functions | Branches | | --- | --- | --- | --- | --- | | Total | 100% | 100% | 100% | 100% | | server/api/controller.ts | 100% | 100% | 100% | 100% | | server/api/router.ts | 100% | 100% | 100% | 100% | | server/client/controller.ts | 100% | 100% | 100% | 100% | | server/client/router.ts | 100% | 100% | 100% | 100% | | server/config/controller.ts | 100% | 100% | 100% | 100% | | server/config/router.ts | 100% | 100% | 100% | 100% | | server/core/app.ts | 100% | 100% | 100% | 100% | | server/core/modules.ts | 100% | 100% | 100% | 100% | | server/log/router.ts | 100% | 100% | 100% | 100% | | server/mockapi/data.ts | 100% | 100% | 100% | 100% | | server/mockapi/router.ts | 100% | 100% | 100% | 100% |

Triggered by commit: a4c0f81b856c372d2e17d7e4a2194803ccd81d9f