search

strimzi / strimzi-ui

Strimzi UI
Apache License 2.0
26 stars 27 forks source link

Use HTTP over Websockets #142

Closed matthew-chirgwin closed 3 years ago

matthew-chirgwin commented 3 years ago

Issue to update the UI to use HTTP (vs Websockets) for data fetching.

Websockets enable GQL subscriptions, where as HTTP does not. However, using server side events, HTTP can be used with a few changes on the client/server.

This issue is to investigate/implement the required changes.

wtrocki commented 3 years ago

Would subscriptions be used to consuming topic information or something else as well?

matthew-chirgwin commented 3 years ago

@wtrocki topics is just the start. In due course (as designs/UX are worked on) I am anticipating the need for 'live' data for more than just topics

@pmuir - I should have asked this yesterday but it slipped my mind. Is it just 'strimzi-admin' websocket traffic which would be an issue, or all websocket traffic? I ask as currently our logging capability uses a websocket from client to server to send logging events

pmuir commented 3 years ago

It's particularly the react frontend -> strimzi-ui server that is an issue.

We would be fine with degrading the UI to not send logging.

wtrocki commented 3 years ago

https://wundergraph.com/blog/deprecate_graphql_subscriptions_over_websockets

Good read

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days