An issue was found in the approach taken to write comments into PRs as a part of the Strimzi UI CI. PR #158 has removed the capability as was to mitigate this. The scope of this issue is to restore the commenter functionality.
The purpose of the commentor is to add helpful/useful information to a PR that a reviewer/raiser may want to take note of. As is today, built bundle sizes, as well as test coverage were calculated and commented on in one workflow. This should be broken down into seperate steps, making use of the workflow_run (https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run) to take the output of all of these, and then write a comment as a result.
Have a step which builds the target branch, and uploads the bundle reports as an artifact
Have a step which builds the branch to be merged, and uploads the bundle report as an artifact
Have a step which runs all jest (which collect code coverage) based tests on the branch, and the generated code coverage result is uploaded as an artifact
Have a new workflow, taking the above three steps artifacts as input, which the drives the commenter action
An issue was found in the approach taken to write comments into PRs as a part of the Strimzi UI CI. PR #158 has removed the capability as was to mitigate this. The scope of this issue is to restore the commenter functionality.
The purpose of the commentor is to add helpful/useful information to a PR that a reviewer/raiser may want to take note of. As is today, built bundle sizes, as well as test coverage were calculated and commented on in one workflow. This should be broken down into seperate steps, making use of the
workflow_run
(https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run) to take the output of all of these, and then write a comment as a result.