search

strindberg / emacsj

Emacs-inspired IntelliJ plugin
MIT License
12 stars 3 forks source link

Control K overriden by Vcs.ToggleAmendCommitMode #59

Open charjr opened 1 week ago

charjr commented 1 week ago

Looking at the Emacs keymap, I can see the following disabled command:

<action id="Vcs.ToggleAmendCommitMode"/>

And the EmacsJ keymap has

<keymap name="EmacsJ" parent="Emacs" version="1.2.0">

Despite this, pressing control + k seems to perform Vcs.ToggleAmendCommitMode.

I don't know why it is not inheriting the behaviour properly.

But perhaps disabling that action explicitly in the keymap would solve it?

strindberg commented 5 days ago

Thank you for the report.

I have not been able to reproduce this: control + k kills the line both with the Emacs and the EmacsJ keymaps in all IntelliJ versions that I have tested. Is it in a particular dialog or editor that you see this problem?

charjr commented 5 days ago

Using PHPStorm when set to the EmacsJ keymap.

I do not experience it using the Emacs keymap.

I am using the new UI, and I am running it on Linux, downloaded as a Snap.

It may well be an issue on my end as your keymap literally inherits from Emacs so I don't see anything wrong with the code.