search

stringparser / runtime

a runtime interface
4 stars 1 forks source link

do not share `stack` with each site #8

Closed stringparser closed 8 years ago

stringparser commented 8 years ago

Setup the context by site, do not pass the stack if wasn't specified. Leave a door open in case its needed using site.context to check before assignment.

Sharing the stack object shouldn't be business of the sites but the stack handlers. This keeps things separated.

This basically serves as an use-case for gulp-runtime but I really think is a good separation of concerns here.

stringparser commented 8 years ago

fix landed in https://github.com/stringparser/runtime/commit/799c0e9b19b0aa33c977ee10493a8ecd62ea08ee and https://github.com/stringparser/runtime/commit/4fe25656b429421d31542a05002a08ba8998f2fa