search

stringsync / vexml

MusicXML to Vexflow
MIT License
20 stars 5 forks source link

Missing: Metronome marks #62

Closed rvilarl closed 1 year ago

jaredjj3 commented 1 year ago

This will be implemented in 31c-MetronomeMarks.xml.

jaredjj3 commented 1 year ago

I'm working on this next.

jaredjj3 commented 1 year ago

@rvilarl, in the lilypond example, which marks would you consider the most commonly used?

image

rvilarl commented 1 year ago

Those with note equal number. But look what the others have implemented.

jaredjj3 commented 1 year ago

This is how vexml renders the lilypond test, which I think covers most cases.

image
jaredjj3 commented 1 year ago

Ah, I didn't pay close attention to the beat values — they seem wrong. I'm going to take a closer look. Sorry about the noise.