stringsync / vexml

MusicXML to Vexflow
MIT License
18 stars 4 forks source link

Challenge: Generate code for Joplin - Gladiolus Rag #78

Open rvilarl opened 1 year ago

rvilarl commented 1 year ago

The good news: no crash reading the XML file. The challenge: quite a few things to fix.

image

rvilarl commented 1 year ago

Our target :)

image

jaredjj3 commented 1 year ago

I like this approach. It gives us concrete bugs to work on. The cross-staff notations are particularly interesting.

jaredjj3 commented 9 months ago

@rvilarl, would you attach the MusicXML file somewhere in this issue please?

rvilarl commented 9 months ago

The score is this one https://musescore.com/user/58480/scores/1749906

rvilarl commented 8 months ago

@jaredjj3 the score produces this fault at https://vexml.dev/

Gladiolus_Rag__Scott_Joplin__1907.zip

17:12:14.620 (1296px) Error: [RuntimeError] BadArguments: Too few notes for beam. at new sf (https://vexml.dev/assets/index-e7Ei05G8.js:60:246688) at Wo.render (https://vexml.dev/assets/index-e7Ei05G8.js:60:1213988) at https://vexml.dev/assets/index-e7Ei05G8.js:60:1224036 at Array.map () at Jh.render (https://vexml.dev/assets/index-e7Ei05G8.js:60:1224027) at Zs.render (https://vexml.dev/assets/index-e7Ei05G8.js:61:5105) at mr.render (https://vexml.dev/assets/index-e7Ei05G8.js:63:174) at https://vexml.dev/assets/index-e7Ei05G8.js:63:7625 at Dc (https://vexml.dev/assets/index-e7Ei05G8.js:40:24283) at Ss (https://vexml.dev/assets/index-e7Ei05G8.js:40:42406)

jaredjj3 commented 8 months ago

Good catch, I think we can fix this by adding a check here and making the BeamRendering.vexflow.beam nullable.

rvilarl commented 7 months ago

The cross staff notations are no longer there in measure 5

image

rvilarl commented 7 months ago

@jaredjj3 also starting on measure 10 the second staff is missing.

image

jaredjj3 commented 7 months ago

There must be a bug with beaming. This will be a good score to thoroughly test the system.

jaredjj3 commented 3 months ago

I'm going to take another stab at this before going back to lilypond specs. Here's what I plan to work on:

vexml_dev_0_0_0 (1)