Open rvilarl opened 1 year ago
Our target :)
I like this approach. It gives us concrete bugs to work on. The cross-staff notations are particularly interesting.
@rvilarl, would you attach the MusicXML file somewhere in this issue please?
The score is this one https://musescore.com/user/58480/scores/1749906
@jaredjj3 the score produces this fault at https://vexml.dev/
Gladiolus_Rag__Scott_Joplin__1907.zip
17:12:14.620 (1296px) Error: [RuntimeError] BadArguments: Too few notes for beam. at new sf (https://vexml.dev/assets/index-e7Ei05G8.js:60:246688) at Wo.render (https://vexml.dev/assets/index-e7Ei05G8.js:60:1213988) at https://vexml.dev/assets/index-e7Ei05G8.js:60:1224036 at Array.map (
Good catch, I think we can fix this by adding a check here and making the BeamRendering.vexflow.beam
nullable.
The cross staff notations are no longer there in measure 5
@jaredjj3 also starting on measure 10 the second staff is missing.
There must be a bug with beaming. This will be a good score to thoroughly test the system.
I'm going to take another stab at this before going back to lilypond specs. Here's what I plan to work on:
StaveTie
height, part distance, or both.
The good news: no crash reading the XML file. The challenge: quite a few things to fix.