search

stripcode / pigpio-stepper-motor

Control stepper motor over pigpio using python3 on Raspberry Pi
MIT License
15 stars 6 forks source link

Lovely github project. Shadey PyPi project. #1

Open RichardBronosky opened 6 years ago

RichardBronosky commented 6 years ago

I like the brevity of your project. I would favor it over this other However, your PyPi project is bare compared to the other's

I know it's been a while, but are you interested in sprucing things up? I'd like to help. I also have some ideas about your step patterns.

  1. What you have labeled as fullStepSequence is actually "wave stepping". (As I understand it wave stepping is 25% duty cycle and full stepping is 50%, or "two coils on at all times")
  2. I could replace your tables with algorithms.
stripcode commented 6 years ago

I'm glad you liked my project.

  1. You're right - there is an error. I'll fix it.
  2. I would not want to change the table to the algorithm. Tables provide a visual representation. So more clearly as the stepper motor makes steps.

If you have ideas that you can add write them.

RichardBronosky commented 6 years ago

I totally understand about the table. I'm always torn between the virtues.

Don't forget about your PyPi project. I still think that people care about that after doing pip search stepper produces multiple results.