search

stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala
Other
391 stars 50 forks source link

Make brushfire buildable in both 2.10 and 2.11 #34

Closed colinmarc closed 9 years ago

colinmarc commented 9 years ago

r? @avibryant

avibryant commented 9 years ago

So how does one do a 2.10 build with this?

colinmarc commented 9 years ago

You have to specify scala.version and scala.binary.version. So for example:

mvn -Dscala.version=2.10.4 -Dscala.binary.version=2.10 clean package

colinmarc commented 9 years ago

This builds (and deploys) brushfire-core and brushfire-scalding just fine, but not brushfire-finatra, because there's no finatra for 2.11: https://github.com/twitter/finatra/pull/185

avibryant commented 9 years ago

Ok so let's have it default to 2.10 then so it all builds, then we can have a somewhat more manual process to get the 2.11 artifacts?

colinmarc commented 9 years ago

Makes sense. The build works now.