search

stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala
Other
391 stars 50 forks source link

Use SBT instead of Maven for builds. #44

Closed tixxit closed 9 years ago

tixxit commented 9 years ago

This switches the build to use SBT instead of Maven. This also fixes the current problems with the build (shade doesn't run). It may require tweaks to get publishing working (/cc @colinmarc ?). Let me know how you all feel about this/SBT.

tixxit commented 9 years ago

Sweet - Travis completed! Just need some tests :)

colinmarc commented 9 years ago

I had a strong negative reaction to the title of this PR - I'm not the biggest fan of SBT =p. But this does seem much cleaner. I guess my position would be that we should avoid the proliferation of build tools, and be consistent internally. Maven is used everywhere internally, so I understand shading/crossbuilding/publishing with it much better.

Can you explain the issue with shading? What were we using that for?

avibryant commented 9 years ago

I'm in favor of this for two reasons: first, sbt is more standard/expected for scala OSS projects, so it seems like a plus to be using that here. Second, I think it's useful for us to get some experience with sbt internally in case we decide we want to switch.

(Despite the fact that I am personally much more comfortable at present with maven than I am with sbt).

colinmarc commented 9 years ago

That makes sense to me.

tixxit commented 9 years ago

Anyone mind if I merge?

colinmarc commented 9 years ago

:shipit: !