stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala
Other
391 stars 50 forks source link

DispatchedSplitter should be a case class, consistent with other splitters. #65

Closed NathanHowell closed 9 years ago

NathanHowell commented 9 years ago

This also has the benefit of inheriting from Serialized, which is required for Spark based training and model evaluation.

avibryant commented 9 years ago

You should also change the creation of DispatchedSplitter in Defaults.scala, right?

NathanHowell commented 9 years ago

I've updated it, as well as a few other formatting tweaks.

NathanHowell commented 9 years ago

With case classes the generated apply method on the companion object just calls new, so it wasn't actually needed but is good for consistency.

avibryant commented 9 years ago

Thanks!