Open avibryant opened 8 years ago
@tixxit ok I think this is ready now for review
Got rid of the root
part, and merged with #77 which should now be landed first.
We should probably remove all the commented code in this PR once we agree it is really gone.
This makes a few related changes to
Evaluator
:Split
and just has it directly operate onIterable[T]
, which was the only part of aSplit
it ever cared about anyway.Evaluator
to a tree or sub-tree, which could be useful in various ways in the future (eg if we want to changeSplitter
to produce candidate sub-trees instead of splits)Iterable[T]
represents the leaves of the sub-tree, and so it's now labeled as suchInfinity
to represent an unacceptable level of error, it now returnsOption[Double]
so you can returnNone
to signal thatSplit
, just the errorT
is now also provided. None of the evaluators makes use of it, but there are at least two potential uses I have in mind:T
to the rootT
(eg, "all leaves must contain at least X% of the input Ys")This is WIP because I haven't fully updated the training code to make use of it.