Add annotation support to json serializers.

stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala

Other

391 stars 50 forks source link

Add annotation support to json serializers. #82

Closed tixxit closed 8 years ago

tixxit commented 8 years ago

This let's us (de)serialize our annotations, which we previously just didn't support.

cc @avibryant @striation

erik-stripe commented 8 years ago

Looks reasonable to me. I'm glad you moved the semigroup instance from the tree to the methods that need it. Other than commenting the usage of the WithFallback machinery it looks good to me.