search

stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala
Other
391 stars 50 forks source link

This commit tightens up Brushfire's JSON injections. #85

Closed erik-stripe closed 8 years ago

erik-stripe commented 8 years ago

Previously, we would accept a lot of values which weren't precisely what Brushfire produced. In my opinion this was potentially error-prone, since it might cause future parsing probles that we woudn't easily detect.

It also adds a test to ensure that our injections will never throw exceptions on the inverse function, even when fed arbitrary JSON.

tixxit commented 8 years ago

Verified against a couple of our migrated models :+1: