stripe-archive / brushfire

Distributed decision tree ensemble learning in Scala
Other
391 stars 50 forks source link

Require full orderings for nominal/sparse #86

Closed tixxit closed 8 years ago

tixxit commented 8 years ago

Now that we always use Ordering[V] for all predicate comparisons, we need Dispatched's Ordering to actually handle nominal/sparse cases. This isn't the best solution, since it restricts our nominal/sparse types unnecessarily, but is meant as a stopgap until we switch to using PartialOrderings.

erik-stripe commented 8 years ago

Looks good to me! :+1: