Open erik-stripe opened 8 years ago
Tests are good, but I don't think we need to flesh out the is-present stuff in this PR. Just moving Dispatched
over to using a PartialOrder
would be enough.
OK, that makes sense. I'll do that next.
Alright, Dispatched
is moved over (that was easy!).
I updated this to master, should be able to be merged.
?r @tixxit @johnynek
This looks good to me.
I do think if we are going to use spire more (and we should) we will get mileage out of the algebra work to make algebird, scalding and spire work better together.
That or give up and make a spire-algebird
package that gives conversions between the various typeclasses.
This PR moves brushfire-core over to use
spire.algebra.PartialOrder
andspire.algebra.Order
where applicable. At this point we don't actually use any partial orderings, but the support is there.Before we merge this I'd like to add some tests to prove this is working, and maybe flesh out support for the is present use-case a bit. What do you all think we need?
Review by @tixxit and @avibryant.