Closed gkk-stripe closed 7 years ago
Ok, I downgraded to 0.7.7.
On Wed, Mar 15, 2017 at 11:40 AM, P. Oscar Boykin notifications@github.com wrote:
@johnynek commented on this pull request.
In project/Deps.scala https://github.com/stripe/brushfire/pull/99#discussion_r106250518:
val tDigest = "3.1"
val hadoopClient = "2.5.2" val scalding = "0.16.1-RC3"
- val chill = "0.5.2"
- val chill = "0.9.2"
no. This same argument doesn't apply. For a long time we have been on 2.x of Kryo, all versions <= 0.7 are on that version (all in the last 3 years are 2.21). 0.8.x is on Kryo 3, 0.9 is on Kryo 4.
Basically, Kryo didn't change much for a long time, but then it got a bit more regular and disciplined with releases.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stripe/brushfire/pull/99#discussion_r106250518, or mute the thread https://github.com/notifications/unsubscribe-auth/AXHNbkmVRGhIF34FihX-95UDSgMDppadks5rmDCxgaJpZM4MeSgg .
-- gkk
Here's the patch to apply to try Scala 2.12 locally:
diff --git a/build.sbt b/build.sbt
index 3cdede4..0a70232 100644
--- a/build.sbt
+++ b/build.sbt
@@ -1,6 +1,6 @@
organization in ThisBuild := "com.stripe"
-scalaVersion in ThisBuild := "2.11.5"
+scalaVersion in ThisBuild := "2.12.1"
crossScalaVersions in ThisBuild := Seq("2.10.4", "2.11.5", "2.12.1")
diff --git a/project/Deps.scala b/project/Deps.scala
index 7f873bf..738254d 100644
--- a/project/Deps.scala
+++ b/project/Deps.scala
@@ -8,12 +8,12 @@ object Deps {
object V {
val algebird = "0.13.0"
val jackson = "1.9.13"
- val bonsai = "0.2.1"
+ val bonsai = "0.2.2-SNAPSHOT"
val bijection = "0.9.5"
val tDigest = "3.1"
val hadoopClient = "2.5.2"
- val scalding = "0.16.1-RC3"
+ val scalding = "0.16.1-SNAPSHOT"
val chill = "0.7.7"
val finatra = "1.6.0"
@johnynek ping
LGTM
@tixxit thanks!
Upgrde dependencies to versions that support Scala 2.12. I left two deps intact:
because they don't have Scala 2.12 releases yet. I tested this chnage with locally build SNAPSHOTs of scalding-core and brushfire and all tests passed on Scala 2.12.