search

stripe-archive / jquery.payment

[DEPRECATED] A general purpose library for building credit card forms, validating inputs and formatting numbers.
MIT License
3.53k stars 686 forks source link

Remove 'elo' card type. #248

Closed jenanwise closed 8 years ago

jenanwise commented 8 years ago

r? @shaunstripe

Summary

Remove 'elo' card type.

This is a breaking change. We'll cut a new major release. See #244 for somewhat similar prior removal of a card type.

Motivation

Elo is an important local brand. However, the bin ranges are very scattered, and it impossible with our current implementation to have both comprehensive coverage and a bin pattern list that is not overly long / difficult to maintain.

Users who need Elo can always extend $.payment.cards.

See some discussion in #246.

Testing

Removed Elo test cases. Existing test suite passes.

shaun-stripe commented 8 years ago

Could you update the README to remove mentions of Elo and elo?

jenanwise commented 8 years ago

@shaunstripe Good catch! Done.

shaun-stripe commented 8 years ago

LGTM