search

stripe-contrib / pagerbot

Manage Pagerduty on-call schedules from within your internal chat channels.
https://stripe.com/blog/pagerbot
MIT License
277 stars 90 forks source link

Make "911" and "get" consistent #12

Closed dbenamy closed 9 years ago

dbenamy commented 9 years ago

Right now the syntaxes are:

 911 TEAM [MESSAGE]
 get PERSON [subject SUBJECT]

My vote would be to drop "subject" from "get" since I think that's the more natural thing for people to type.

For bonus points, make "subject" optional for both (but don't list it in help) in case people still use it.

For even more bonus points, make either command work for teams or people although, again, get rid of one from help. So help would only list get <TEAM | PERSON> [MESSAGE] but any of these would work:

pagerbot: 911 sys
pagerbot: get sys the site's down
pagerbot: 911 dbenamy subject unicorns are attacking

What do you think?

raybejjani commented 9 years ago

+1 cause it confused me (but maybe it's that way because of some matching ambiguity?)

chrisgagne commented 9 years ago

+$100 from PagerDuty ;) https://www.bountysource.com/issues/6398038-make-911-and-get-consistent