search

stripe-contrib / pagerbot

Manage Pagerduty on-call schedules from within your internal chat channels.
https://stripe.com/blog/pagerbot
MIT License
277 stars 90 forks source link

Make call_person plugin able to page schedules too #43

Closed dbenamy closed 7 years ago

dbenamy commented 7 years ago

This makes paging teams (or other groups) easier to set up, easier to use, faster to execute, and less error prone, than using the call (911) plugin for this.

Each commit is a self contained chunk to make reviewing easier, although it may not be obvious why I made the change until you see the following one(s).

macobo commented 7 years ago

Added a couple of nits, but this is good stuff! Thanks!

Aside: can you squash the last commit into the one before it?

dbenamy commented 7 years ago

Changed and rebased on master!

macobo commented 7 years ago

This is (manually) merged to master! Thanks!