search

stripe / pg-schema-diff

Go library for diffing Postgres schemas and generating SQL migrations
MIT License
278 stars 20 forks source link

Incorrect usage of lowercase character #57

Closed ksarangmath closed 11 months ago

ksarangmath commented 11 months ago

There is a lowercase T at the beginning of a sentence in a comment. The reference to the line is below. https://github.com/stripe/pg-schema-diff/blob/main/cmd/pg-schema-diff/apply_cmd.go#L145

ksarangmath commented 11 months ago

This is resolved.

ksarangmath commented 11 months ago

Although the previous issue has been resolved, there is a related issue that does not warrant a completely separate issue. Therefore, we will continue in this issue.

There is an incorrect usage of an uppercase character in the following line: https://github.com/stripe/pg-schema-diff/blob/main/README.md?plain=1#L108

ksarangmath commented 11 months ago

@bplunkett-stripe mind taking a look? Let's triage this issue ASAP and circle back offline after the weekend.

ksarangmath commented 11 months ago

https://github.com/stripe/pg-schema-diff/pull/58 handles this