avi-stripe commented 5 years ago

This standardizes the ways to observe event data in a single Events object with a set of observe methods. The implementations here are not new (just moved from other places); the thing to focus on is the naming and choice of signatures. Once choice this makes is for the return value to be to what I believe is the most useful posterior-predictive generator object (eg, for the function variants, it's from Seq[X] => Generator[Seq[(X,Y)]], which (given new feature vectors) produces generated predictive output in the same form as the observed data.)

codecov-io commented 5 years ago

Codecov Report

Merging #365 into develop will decrease coverage by 0.16%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #365      +/-   ##
==========================================
- Coverage    46.46%   46.3%   -0.17%     
==========================================
  Files           84      85       +1     
  Lines         3045    3058      +13     
  Branches       140     146       +6     
==========================================
+ Hits          1415    1416       +1     
- Misses        1630    1642      +12

Impacted Files	Coverage Δ
...rc/main/scala/com/stripe/rainier/core/Events.scala	`0% <0%> (ø)`
...ain/scala/com/stripe/rainier/compute/RealOps.scala	`79.66% <0%> (+0.84%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaf45af...da120eb. Read the comment docs.

avi-stripe commented 5 years ago

merging after IRL convo with @andrew-stripe

stripe / rainier

Events.observe #365

Codecov Report