stripe / rainier

Bayesian inference in Scala.
https://rainier.fit
Apache License 2.0
432 stars 51 forks source link

WAIC #383

Closed avi-stripe closed 4 years ago

avi-stripe commented 4 years ago

An apparently-working implementation of WAIC.

codecov-io commented 4 years ago

Codecov Report

Merging #383 into develop will increase coverage by 0.79%. The diff coverage is 69.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
+ Coverage    46.38%   47.17%   +0.79%     
===========================================
  Files           87       88       +1     
  Lines         3167     3260      +93     
  Branches       159      150       -9     
===========================================
+ Hits          1469     1538      +69     
- Misses        1698     1722      +24
Impacted Files Coverage Δ
...c/main/scala/com/stripe/rainier/repl/package.scala 0% <0%> (ø) :arrow_up:
...scala/com/stripe/rainier/core/RandomVariable.scala 39.02% <0%> (-2.54%) :arrow_down:
.../src/main/scala/com/stripe/rainier/core/WAIC.scala 100% <100%> (ø)
...ain/scala/com/stripe/rainier/compute/RealOps.scala 79.66% <0%> (+0.84%) :arrow_up:
...n/scala/com/stripe/rainier/core/Distribution.scala 100% <0%> (+16.66%) :arrow_up:
...rc/main/scala/com/stripe/rainier/core/Events.scala 16.66% <0%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9900a7...55bca42. Read the comment docs.

avi-stripe commented 4 years ago

@andrew-stripe thanks, I've added the variants to waic and compare.