search

stripe / rainier

Bayesian inference in Scala.
https://rainier.fit
Apache License 2.0
432 stars 51 forks source link

Bring back SBC #410

Closed avibryant closed 4 years ago

avibryant commented 4 years ago

This is an important piece to be able to bring back benchmarks and tests.

Rather than looking at the full file here, you can use this diff to see what's changed since before it was deleted: https://github.com/stripe/rainier/compare/f71a8a705da55148a2a10436796c9f90e108f1a9..991f65d3650195d6f910fd8925f8888015f01486#diff-c279ee7bd4b82e7ee0df025715f7fddf

(This is a fairly small and straightforward update to the new API).

codecov-io commented 4 years ago

Codecov Report

Merging #410 into nukerv-sample will decrease coverage by 1.29%. The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           nukerv-sample     #410     +/-   ##
================================================
- Coverage          32.92%   31.63%   -1.3%     
================================================
  Files                 66       67      +1     
  Lines               2554     2655    +101     
  Branches             133      151     +18     
================================================
- Hits                 841      840      -1     
- Misses              1713     1815    +102
Impacted Files Coverage Δ
...e/src/main/scala/com/stripe/rainier/core/SBC.scala 0% <0%> (ø)
...ain/scala/com/stripe/rainier/compute/RealOps.scala 76.66% <0%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd7abf6...991f65d. Read the comment docs.

avibryant commented 4 years ago

Yeah I don't think it ever got used so seemed simpler to delete than to update.