Closed avibryant closed 4 years ago
Merging #463 into 0.3-dev will increase coverage by
0.23%
. The diff coverage is0%
.
@@ Coverage Diff @@
## 0.3-dev #463 +/- ##
===========================================
+ Coverage 53.04% 53.28% +0.23%
===========================================
Files 72 71 -1
Lines 2771 2783 +12
Branches 172 166 -6
===========================================
+ Hits 1470 1483 +13
+ Misses 1301 1300 -1
Impacted Files | Coverage Δ | |
---|---|---|
...in/scala/com/stripe/rainier/notebook/package.scala | 0% <0%> (ø) |
|
...la/com/stripe/rainier/notebook/ImageModifier.scala | 0% <0%> (ø) |
|
.../main/scala/com/stripe/rainier/core/SBCModel.scala | 74.5% <0%> (-1.5%) |
:arrow_down: |
...src/main/scala/com/stripe/rainier/core/Trace.scala | 8.33% <0%> (-0.56%) |
:arrow_down: |
...src/main/scala/com/stripe/rainier/core/Model.scala | 57.4% <0%> (-0.29%) |
:arrow_down: |
...e/src/main/scala/com/stripe/rainier/core/SBC.scala | 13.86% <0%> (-0.14%) |
:arrow_down: |
...rc/main/scala/com/stripe/rainier/ir/GraphViz.scala | 0% <0%> (ø) |
:arrow_up: |
...rc/main/scala/com/stripe/rainier/compute/Vec.scala | 0% <0%> (ø) |
:arrow_up: |
...ain/scala/com/stripe/rainier/compute/Decimal.scala | 0% <0%> (ø) |
:arrow_up: |
.../com/stripe/rainier/ir/OutputMethodGenerator.scala | 100% <0%> (ø) |
:arrow_up: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 92ba3d2...02fa18f. Read the comment docs.
This PR:
almond.display.Image
instead ofDrawable
. This should be rendered directly in Jupyter (not yet tested).evilplot
mdoc modified that expected aDrawable
to instead beimage
and expect aalmond.display.Image
This lets us use the exact same methods in both contexts.