search

stripe / rainier

Bayesian inference in Scala.
https://rainier.fit
Apache License 2.0
433 stars 51 forks source link

Upgrade Scala #500

Closed kailuowang closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

kailuowang commented 3 years ago

··· [info] SBCTest: [info] - Normal(x, 1) with Uniform(0, 1) prior FAILED [info] 3.1161153960044017E-4 was not less than 1.0E-10 (SBCTest.scala:13) [info] - LogNormal(x, x) with LogNormal(0, 1) prior FAILED [info] 1.0113395350902358E-4 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Exponential(x) with LogNormal(0, 1) prior FAILED [info] 1.639394199525013E-4 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Laplace(x, x) with LogNormal(0, 1) prior FAILED [info] 6.679151815210127E-5 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Gamma(x, x) with LogNormal(0, 1) prior FAILED [info] 2.9566599451501842E-5 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Bernoulli(x) with Uniform(0, 1) prior FAILED [info] 5.39389756538608E-6 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Binomial(x, 10) with Uniform(0, 1) prior FAILED [info] 3.224556969637731E-5 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Poisson approximation to Binomial: Binomial(x, 200) with Uniform(0, 0.04) prior FAILED [info] 3.826612885650739E-6 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Geometric(x) with Uniform(0, 1) prior FAILED [info] 3.861863757964571E-6 was not less than 1.0E-10 (SBCTest.scala:13) [info] - NegativeBinomial(x, 10) with Uniform(0, 1) prior FAILED [info] 2.025381761294234E-5 was not less than 1.0E-10 (SBCTest.scala:13) [info] - Poisson(x*1000) with Uniform(0.8, 1) prior FAILED [info] 4.271366195830918E-6 was not less than 1.0E-10 (SBCTest.scala:13) ···

I am not sure how to fix these SBC tests. It's weird that a minor scala update from 2.12.11 to 2.12.12. I am going to revert that 2.12 change and see how 2.13.5 goes

kailuowang commented 3 years ago

closing this outdated PR