change publish to sonatype

stripe / rainier

Bayesian inference in Scala.

https://rainier.fit

Apache License 2.0

433 stars 51 forks source link

change publish to sonatype #501

Closed kailuowang closed 3 years ago

kailuowang commented 3 years ago

to actually publish, two env variables are needed "SONATYPE_USERNAME" and "SONATYPE_PASSWORD" These can be set to a sonatype login token, which can be generated following the steps here

kailuowang commented 3 years ago

these tests seem to be failing prior to these changes in my other PR as well.

avibryant commented 3 years ago

@kailuowang those tests are sensitive to RNG. I wonder if maybe the JVM being used to run the tests in CI has changed or and its RNG is different? Or alternatively something around FP math settings?

kailuowang commented 3 years ago

Jvm was changed since the old gh action step is no longer supported. I am using the official Scala action step now. Can we change the tests to expect the new values?

avibryant commented 3 years ago

@kailuowang ok, yes, that's a bit of a lengthy process because we have to re-run the Simulation-Based Calibration to make sure the posteriors still look ok, but I have reproduced the test failures by switching to JDK 11 on my machine so I can work on that.

avibryant commented 3 years ago

@kailuowang should pass after merging with https://github.com/stripe/rainier/pull/502

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kailuowang
:x: avibryant
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

kailuowang commented 3 years ago

@avibryant I merged in your commits, the build passes, but the CLAssistant got confused.