stripe / react-connect-js

React components for Connect.js and Connect embedded components
https://stripe.com/docs/connect/get-started-connect-embedded-components
MIT License
20 stars 8 forks source link

Build error because of CommonComponentProps #107

Closed djshubs closed 1 month ago

djshubs commented 1 month ago

My builds started to fail because of onLoadError and onLoaderStart now being required props. However, the docs say they're optional.

Link - https://docs.stripe.com/connect/supported-embedded-components/payment-details

what is expected behavior here? and what's the purpose of the onLoadError and onLoaderStart?


        <ConnectPaymentDetails
          payment={paymentId}
          onClose={() => setOpen(false)}
          key={paymentId}
          onLoadError={({ error, elementTagName }: LoadError) => {
            console.log('Error loading payment details', error);
            captureException({ error, elementTagName });
          }}
          onLoaderStart={() => undefined}
        />
jorgea-stripe commented 1 month ago

Hey @djshubs , thanks for reporting! They are optional. We'll fix this issue.

jorgea-stripe commented 1 month ago

This has been published now, apologies for the break!