stripe / skycfg

Skycfg is an extension library for the Starlark language that adds support for constructing Protocol Buffer messages.
Apache License 2.0
646 stars 54 forks source link

Fixing error message for custom entrypoint #101

Closed henryc-stripe closed 2 years ago

henryc-stripe commented 2 years ago

Summary

Skycfg's entrypoint is usually a main() function, but users are allowed to specify a custom function name if they wish. However, error messages always have the entrypoint hardcoded to "main", which is confusing for users specifying a custom entrypoint.

For example, if a user has a custom entrypoint function named my_entrypoint and uses the option skycfg.WithEntryPoint("my_entryponit") (which has a typo), they will be presented with the error message no 'main' function found in "file.sky", while a more appropriate error message would be no 'my_entryponit' function found in "file.sky". This PR changes the error message so it always uses the entrypoint provided by the user.