search

stripe / skycfg

Skycfg is an extension library for the Starlark language that adds support for constructing Protocol Buffer messages.
Apache License 2.0
643 stars 54 forks source link

Implement starlark.Comparable for enums. #77

Closed dilyevsky closed 4 years ago

dilyevsky commented 4 years ago

Implement starlark.Comparable interface for skyProtoEnumValue to handle enum comparison correctly. Only supports == and != operations.

Fixes https://github.com/stripe/skycfg/issues/76

jmillikin-stripe commented 4 years ago

Hah, I was literally just working on this and saw the github notification after I created https://github.com/stripe/skycfg/pull/78.

I'll add some comments here too.