search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.28k stars 644 forks source link

Duplicate card number prefix #55

Closed carotorrehdz closed 8 years ago

carotorrehdz commented 8 years ago

Just wondering if there was a mistake on this line https://github.com/stripe/stripe-android/blob/master/stripe/src/main/java/com/stripe/android/model/Card.java#L19 or why is it that you are including 37 as a Diners Club prefix if according to your source page https://en.wikipedia.org/wiki/Bank_card_number#Issuer_identification_number_.28IIN.29 it clearly exclude 37

olivierbellone commented 8 years ago

Hi @caroth92, thanks for reporting this! Thankfully this shouldn't cause any issues because we first check for American Express' prefixes, which also include 37.

Nevertheless, I submitted a PR to fix this: #57