stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.29k stars 646 forks source link

[BUG] Wrong title "Front of identity card" #8511

Open googol7 opened 5 months ago

googol7 commented 5 months ago

Summary

We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".

In German this translates to "Vorderseite des Personalausweises" which is not a driving license.

See also:

Version

The problem occurs with stripe-android v20.44.0

Details

We currently only accept driver's licences by defining options.document.allowed_types = ["driving_license"] when using the API

Available options are:

The optimal solution would be that the title corresponds exactly with options.document.allowed_types. This is how the web version already does it.

Example: options.document.allowed_types string used
["driving_license"] <string name="stripe_front_of_dl">Front of driver\'s license</string>
["id_card"] <string name="stripe_front_of_id">Front of identity card</string>
["passport"] <string name="stripe_passport">Passport</string>
["driving_license", "id_card", "passport"] <string name="stripe_front_of_id_document">Front of identity document</string>

But in the interface the title is always "Front of identity card" (stripe_front_of_id)

The text is stripe_position_id_front: "Position your identity card in the centre of the frame".

In the code you only use stripe_front_of_id here.

The strings stripe_front_of_dl "Front of driving licence" and "Back of driving licence" (stripe_back_of_dl) are defined but not used in the code.

Android Native - English 2


On the first screen you use: "Get ready to scan your photo ID" which is defined here.

Android Native - English 1

googol7 commented 4 months ago

@ccen-stripe I've seen that the problem seems to be solved on iOS but not yet on Android.

googol7 commented 3 months ago

@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:

  1. Get ready to scan your driver's license Grab your driver's license
  2. Front of driver's license
  3. Flip your ID over Get ready to scan the back of your ID
  4. Back of driver's license

0 1 2 3 4

googol7 commented 2 months ago

I've seen that with this commit in the PR

these new translations were added:

<string name="stripe_front_of_id_document">Front of identity document</string>
<string name="stripe_back_of_id_document">Back of identity document</string>

but they are not used in the code yet.

dbartenstein commented 1 month ago

Would be great to have that one fixed soon!

LucaB01 commented 1 month ago

Would be awesome if this gets fixed!