search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.23k stars 628 forks source link

Wait for Bacs sort code and account number to appear on screen in tests #8676

Closed amk-stripe closed 6 days ago

amk-stripe commented 6 days ago

Summary

Wait for Bacs sort code and account number to appear on screen in tests

Motivation

Noticed that this was flaky while testing locally. We also know that this test is flaky in general, so hoping this improves these tests!

Testing

CI confirms that the tests that use this still pass

github-actions[bot] commented 6 days ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +3 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +3 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21651 │ 21651 │ 0 (+0 -0) 
   types │  6873 │  6873 │ 0 (+0 -0) 
 classes │  5638 │  5638 │ 0 (+0 -0) 
 methods │ 31466 │ 31466 │ 0 (+0 -0) 
  fields │ 18327 │ 18327 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────┼───────────┬──────┤ size │ diff │ size │ diff │ path ──────────┼──────┼───────────┼──────┼──────────────────────── 25.9 KiB │ +2 B │ 63.9 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 29.1 KiB │ +1 B │ 64 KiB │ 0 B │ ∆ META-INF/CERT.SF ──────────┼──────┼───────────┼──────┼──────────────────────── 54.9 KiB │ +3 B │ 127.9 KiB │ 0 B │ (total) ```