search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.23k stars 628 forks source link

Handle wallets correctly in flow controller vertical mode. #8681

Closed jaynewstrom-stripe closed 6 days ago

jaynewstrom-stripe commented 6 days ago

Summary

Adds the new logic for wallets in vertical mode for flow controller.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2099

Testing

https://github.com/stripe/stripe-android/assets/116920913/361191f7-1915-44e1-9fb2-1abe3dec0890

github-actions[bot] commented 6 days ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │  86.9 KiB │  86.9 KiB │ +2 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +2 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21651 │ 21651 │ 0 (+0 -0) 
   types │  6873 │  6873 │ 0 (+0 -0) 
 classes │  5638 │  5638 │ 0 (+0 -0) 
 methods │ 31466 │ 31466 │ 0 (+0 -0) 
  fields │ 18327 │ 18327 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────┼──────────┬──────┤ size │ diff │ size │ diff │ path ──────────┼──────┼──────────┼──────┼─────────────────────────────────────────── 29.1 KiB │ +4 B │ 64 KiB │ 0 B │ ∆ META-INF/CERT.SF 1.2 KiB │ -3 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA 272 B │ +1 B │ 120 B │ 0 B │ ∆ META-INF/version-control-info.textproto ──────────┼──────┼──────────┼──────┼─────────────────────────────────────────── 30.5 KiB │ +2 B │ 65.3 KiB │ 0 B │ (total) ```