Open tillh-stripe opened 5 days ago
Diffuse output:
OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)
│ compressed │ uncompressed
├─────────────┬─────────────┬───────┼─────────────┬─────────────┬──────
APK │ old │ new │ diff │ old │ new │ diff
──────────┼─────────────┼─────────────┼───────┼─────────────┼─────────────┼──────
dex │ 2 MiB │ 2 MiB │ 0 B │ 4.2 MiB │ 4.2 MiB │ 0 B
arsc │ 1,023.8 KiB │ 1,023.8 KiB │ 0 B │ 1,023.7 KiB │ 1,023.7 KiB │ 0 B
manifest │ 2.3 KiB │ 2.3 KiB │ 0 B │ 8 KiB │ 8 KiB │ 0 B
res │ 301.5 KiB │ 301.5 KiB │ 0 B │ 455 KiB │ 455 KiB │ 0 B
native │ 6.2 MiB │ 6.2 MiB │ 0 B │ 15.8 MiB │ 15.8 MiB │ 0 B
asset │ 6.7 KiB │ 6.7 KiB │ 0 B │ 6.5 KiB │ 6.5 KiB │ 0 B
other │ 85.5 KiB │ 85.5 KiB │ +10 B │ 158.7 KiB │ 158.7 KiB │ 0 B
──────────┼─────────────┼─────────────┼───────┼─────────────┼─────────────┼──────
total │ 9.6 MiB │ 9.6 MiB │ +10 B │ 21.6 MiB │ 21.6 MiB │ 0 B
DEX │ old │ new │ diff
─────────┼───────┼───────┼───────────
files │ 1 │ 1 │ 0
strings │ 21305 │ 21305 │ 0 (+0 -0)
types │ 6770 │ 6770 │ 0 (+0 -0)
classes │ 5559 │ 5559 │ 0 (+0 -0)
methods │ 31121 │ 31121 │ 0 (+0 -0)
fields │ 18141 │ 18141 │ 0 (+0 -0)
ARSC │ old │ new │ diff
─────────┼──────┼──────┼──────
configs │ 164 │ 164 │ 0
entries │ 3392 │ 3392 │ 0
Looking good! I noticed in the 'after' that the bank logos load simultaneously, vs. the 'before' where a few logos loaded first and then the rest loaded afterward. Is that a change related to this PR? Or just happened to be the case during the recording?
Summary
This pull request adds proper pane slide transitions in the bank auth flow, and a fade effect for the Stripe logo in the top bar.
We exclude the attach-payment screen from the slide transitions, as it would just cause a slide from one loading indicator to another (we use a fade instead).
(cc @malecks-stripe)
Motivation
Testing
Screen recordings
Before
https://github.com/stripe/stripe-android/assets/110940675/660fb0e7-742f-4a44-946a-9774c0d133d7
After
https://github.com/stripe/stripe-android/assets/110940675/fcd53593-3b8f-429f-92dc-295216985f0c
Changelog