stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.27k stars 640 forks source link

Remove usesCleartextTraffic from identity SDK #8683

Closed jaynewstrom-stripe closed 3 months ago

jaynewstrom-stripe commented 3 months ago

This reverts commit 435facbb7ae3ab56ab32f9c9e08eac416b7ba81b.

Fixes https://github.com/stripe/stripe-android/issues/8666

Summary

The reason this was introduced is no longer in use, so it's not needed.

github-actions[bot] commented 3 months ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │     2 MiB │     2 MiB │   0 B │   4.3 MiB │   4.3 MiB │   0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │   0 B 
 manifest │   2.3 KiB │   2.3 KiB │ -33 B │   8.1 KiB │     8 KiB │ -72 B 
      res │ 301.5 KiB │ 301.5 KiB │   0 B │   455 KiB │   455 KiB │   0 B 
   native │   7.3 MiB │   7.3 MiB │   0 B │  18.4 MiB │  18.4 MiB │   0 B 
    asset │   1.5 MiB │   1.5 MiB │   0 B │   1.5 MiB │   1.5 MiB │   0 B 
    other │  86.9 KiB │  86.9 KiB │  -5 B │ 161.5 KiB │ 161.5 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  12.2 MiB │  12.2 MiB │ -38 B │  25.8 MiB │  25.8 MiB │ -72 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21651 │ 21651 │ 0 (+0 -0) 
   types │  6873 │  6873 │ 0 (+0 -0) 
 classes │  5638 │  5638 │ 0 (+0 -0) 
 methods │ 31466 │ 31466 │ 0 (+0 -0) 
  fields │ 18327 │ 18327 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK ``` compressed │ uncompressed │ ──────────┬───────┼───────────┬───────┤ size │ diff │ size │ diff │ path ──────────┼───────┼───────────┼───────┼─────────────────────────────────────────── 2.3 KiB │ -33 B │ 8 KiB │ -72 B │ ∆ AndroidManifest.xml 25.9 KiB │ -6 B │ 63.9 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 272 B │ +3 B │ 120 B │ 0 B │ ∆ META-INF/version-control-info.textproto 1.2 KiB │ -3 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA 29.1 KiB │ +1 B │ 64 KiB │ 0 B │ ∆ META-INF/CERT.SF ──────────┼───────┼───────────┼───────┼─────────────────────────────────────────── 58.6 KiB │ -38 B │ 137.2 KiB │ -72 B │ (total) ```
MANIFEST ``` @@ -47,3 +47,2 @@ android:theme=@style/Theme.Theme1 - android:usesCleartextTraffic=true > ```