stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.27k stars 640 forks source link

Add mandate for vertical mode. #8693

Closed jaynewstrom-stripe closed 3 months ago

jaynewstrom-stripe commented 3 months ago

Summary

Adds mandates to the vertical mode list for new payment methods that require a mandate, but not other fields.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2114

Testing

https://github.com/stripe/stripe-android/assets/116920913/8aa89b88-9f0e-4307-8ec7-a5492d166f2a

github-actions[bot] commented 3 months ago

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │     4 MiB │     4 MiB │   +168 B │   8.7 MiB │   8.7 MiB │   +708 B 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │      0 B 
      res │ 918.5 KiB │ 918.5 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │ -1.4 KiB │   2.9 MiB │   2.9 MiB │ -1.4 KiB 
    other │   195 KiB │   195 KiB │     -6 B │ 428.4 KiB │ 428.4 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ -1.2 KiB │  21.8 MiB │  21.8 MiB │   -728 B 

 DEX     │ old   │ new   │ diff          
─────────┼───────┼───────┼───────────────
   files │     1 │     1 │   0           
 strings │ 43552 │ 43552 │   0 (+1 -1)   
   types │ 14972 │ 14972 │   0 (+0 -0)   
 classes │ 12656 │ 12656 │   0 (+0 -0)   
 methods │ 61964 │ 61976 │ +12 (+29 -17) 
  fields │ 40889 │ 40893 │  +4 (+6 -2)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6043 │ 6043 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────────┼───────────┬──────────┤ size │ diff │ size │ diff │ path ──────────┼──────────┼───────────┼──────────┼─────────────────────────────── 6 KiB │ -1.4 KiB │ 5.9 KiB │ -1.4 KiB │ ∆ assets/dexopt/baseline.prof 4 MiB │ +168 B │ 8.7 MiB │ +708 B │ ∆ classes.dex 49.6 KiB │ -8 B │ 117.1 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 52.9 KiB │ +4 B │ 117.2 KiB │ 0 B │ ∆ META-INF/CERT.SF 1.2 KiB │ -2 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA ──────────┼──────────┼───────────┼──────────┼─────────────────────────────── 4.1 MiB │ -1.2 KiB │ 9 MiB │ -728 B │ (total) ```
DEX ``` STRINGS: old │ new │ diff ───────┼───────┼─────────── 43552 │ 43552 │ 0 (+1 -1) + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:978c2fe,r8-mode:full,version:8.3.37} - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:ae43989,r8-mode:full,version:8.3.37} METHODS: old │ new │ diff ───────┼───────┼─────────────── 61964 │ 61976 │ +12 (+29 -17) + G6.O1 N(O1, e) → Object + G6.O1 O(O1, C) + G6.O1 P(c) → Object + G6.O1 Q() + G6.O1 R(A, A1) + G6.O1 S(A) + G6.O1 T(h1, boolean) + G6.O1 U(N2, I, e) → Object + G6.O1 V(J, e) → Object + G6.O1 W() → boolean + G6.O1 X(Throwable) + G6.O1 Y(N2, C) + G6.O1 Z(String) + G6.v0 M() + a8.I1 e() → b + a8.J e() → b + a8.L0 e() → b + a8.Y1 e() → b + a8.c0 e() → b + a8.d e() → b + a8.h e() → b + a8.p1 e() → b + a8.q e() → b + h8.M0 e() → b + h8.M e() → b + h8.W e() → b + h8.t e() → b + s7.A K(String, boolean) + s7.A L(A) - G6.O1 L(O1, e) → Object - G6.O1 N(O1, C) - G6.O1 O(c) → Object - G6.O1 P() - G6.O1 Q(A, A1) - G6.O1 R(A) - G6.O1 S(h1, boolean) - G6.O1 T(N2, I, e) → Object - G6.O1 U(J, e) → Object - G6.O1 V() → boolean - G6.O1 W(Throwable) - G6.O1 X(N2, C) - G6.O1 Y(String) - G6.v0 L() - a8.U1 () - a8.f0 () - s7.A K(A) FIELDS: old │ new │ diff ───────┼───────┼──────────── 40889 │ 40893 │ +4 (+6 -2) + a8.p1 e: a + a8.q d: a + h8.M0 e: b + r7.k m: c + r7.k n: ArrayList + r7.k p: b - r7.k m: ArrayList - r7.k n: b ```