search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.27k stars 640 forks source link

Add CVC Error display to CvcRecollectionField #8703

Closed tjclawson-stripe closed 3 months ago

tjclawson-stripe commented 3 months ago

Summary

Add SectionError field to composable to display CVC errors Also change "Confirm your CVC" text color to subtitle

Motivation

Bug Bash

Testing

Screenshots

Before After
Screenshot_1719446588 Screenshot_1719595542

Changelog

github-actions[bot] commented 3 months ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed           
          ├─────────────┬─────────────┬───────┼─────────────┬─────────────┬──────
 APK      │ old         │ new         │ diff  │ old         │ new         │ diff 
──────────┼─────────────┼─────────────┼───────┼─────────────┼─────────────┼──────
      dex │       2 MiB │       2 MiB │   0 B │     4.2 MiB │     4.2 MiB │  0 B 
     arsc │ 1,023.8 KiB │ 1,023.8 KiB │   0 B │ 1,023.7 KiB │ 1,023.7 KiB │  0 B 
 manifest │     2.3 KiB │     2.3 KiB │   0 B │       8 KiB │       8 KiB │  0 B 
      res │   301.5 KiB │   301.5 KiB │   0 B │     455 KiB │     455 KiB │  0 B 
   native │     6.2 MiB │     6.2 MiB │   0 B │    15.8 MiB │    15.8 MiB │  0 B 
    asset │     6.7 KiB │     6.7 KiB │   0 B │     6.5 KiB │     6.5 KiB │  0 B 
    other │    85.5 KiB │    85.5 KiB │ +11 B │   158.7 KiB │   158.7 KiB │  0 B 
──────────┼─────────────┼─────────────┼───────┼─────────────┼─────────────┼──────
    total │     9.6 MiB │     9.6 MiB │ +11 B │    21.6 MiB │    21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21305 │ 21305 │ 0 (+0 -0) 
   types │  6770 │  6770 │ 0 (+0 -0) 
 classes │  5559 │  5559 │ 0 (+0 -0) 
 methods │ 31121 │ 31121 │ 0 (+0 -0) 
  fields │ 18141 │ 18141 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3392 │ 3392 │  0
APK ``` compressed │ uncompressed │ ──────────┬───────┼───────────┬──────┤ size │ diff │ size │ diff │ path ──────────┼───────┼───────────┼──────┼──────────────────────── 28.3 KiB │ +4 B │ 62.6 KiB │ 0 B │ ∆ META-INF/CERT.SF 25.1 KiB │ +4 B │ 62.5 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 1.2 KiB │ +3 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA ──────────┼───────┼───────────┼──────┼──────────────────────── 54.6 KiB │ +11 B │ 126.3 KiB │ 0 B │ (total) ```
tjclawson-stripe commented 3 months ago

Let's add some screenshot tests for the error as well!

Updated 👍