stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.27k stars 640 forks source link

Increase limit to 100 when fetching payment methods in `CustomerRepository` for PS, FC, and CS. #8714

Closed samer-stripe closed 2 months ago

samer-stripe commented 3 months ago

Summary

Increase limit to 100 when fetching payment methods in CustomerRepository for PS, FC, and CS.

Motivation

Since we didn't provide a limit initially, the limit was set to 10 by the Stripe API. Wallet LPMs are overshadowing non-wallet LPMs when fetching payment methods. If a user has 10 wallet LPMs show up before their none-wallet LPMs, it will appear as if they have no LPMs due to our client-side filtering logic that filters out wallet LPMs.

As a bandaid fix, we will increase the limit to 100 until we have a better API integration for filtering out wallet LPMs.

Testing

github-actions[bot] commented 2 months ago

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├─────────────┬─────────────┬──────┼─────────────┬─────────────┬──────
 APK      │ old         │ new         │ diff │ old         │ new         │ diff 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
      dex │       2 MiB │       2 MiB │  0 B │     4.2 MiB │     4.2 MiB │  0 B 
     arsc │ 1,023.8 KiB │ 1,023.8 KiB │  0 B │ 1,023.7 KiB │ 1,023.7 KiB │  0 B 
 manifest │     2.3 KiB │     2.3 KiB │  0 B │       8 KiB │       8 KiB │  0 B 
      res │   301.5 KiB │   301.5 KiB │  0 B │     455 KiB │     455 KiB │  0 B 
   native │     6.2 MiB │     6.2 MiB │  0 B │    15.8 MiB │    15.8 MiB │  0 B 
    asset │     6.7 KiB │     6.7 KiB │  0 B │     6.5 KiB │     6.5 KiB │  0 B 
    other │    85.5 KiB │    85.5 KiB │ -7 B │   158.7 KiB │   158.7 KiB │  0 B 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
    total │     9.6 MiB │     9.6 MiB │ -7 B │    21.6 MiB │    21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21305 │ 21305 │ 0 (+0 -0) 
   types │  6770 │  6770 │ 0 (+0 -0) 
 classes │  5559 │  5559 │ 0 (+0 -0) 
 methods │ 31121 │ 31121 │ 0 (+0 -0) 
  fields │ 18141 │ 18141 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3392 │ 3392 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────┼──────────┬──────┤ size │ diff │ size │ diff │ path ──────────┼──────┼──────────┼──────┼─────────────────────────────────────────── 25.1 KiB │ -6 B │ 62.5 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 1.2 KiB │ -2 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA 272 B │ +1 B │ 120 B │ 0 B │ ∆ META-INF/version-control-info.textproto ──────────┼──────┼──────────┼──────┼─────────────────────────────────────────── 26.5 KiB │ -7 B │ 63.8 KiB │ 0 B │ (total) ```