search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.27k stars 640 forks source link

Remove CVC Feature Flag and RestrictTo annotations #8717

Closed tjclawson-stripe closed 3 months ago

tjclawson-stripe commented 3 months ago

Summary

Remove FeatureFlags.cvcRecollectionEnabled Remove RestrictTo annotations on CVC related methods/classes

Motivation

Testing

Changelog

github-actions[bot] commented 3 months ago

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │     4 MiB │     4 MiB │ +1.1 KiB │   8.7 MiB │   8.7 MiB │   +856 B 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │      0 B 
      res │ 918.5 KiB │ 918.5 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │ +1.4 KiB │   2.9 MiB │   2.9 MiB │ +1.4 KiB 
    other │   195 KiB │   195 KiB │     +4 B │ 428.4 KiB │ 428.4 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ +2.5 KiB │  21.8 MiB │  21.8 MiB │ +2.2 KiB 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 43585 │ 43586 │ +1 (+4 -3)     
   types │ 14988 │ 14988 │  0 (+2 -2)     
 classes │ 12670 │ 12670 │  0 (+1 -1)     
 methods │ 62032 │ 62034 │ +2 (+203 -201) 
  fields │ 40957 │ 40958 │ +1 (+26 -25)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6043 │ 6043 │  0
APK ``` compressed │ uncompressed │ ──────────┬──────────┼───────────┬──────────┤ size │ diff │ size │ diff │ path ──────────┼──────────┼───────────┼──────────┼─────────────────────────────── 7.4 KiB │ +1.4 KiB │ 7.2 KiB │ +1.4 KiB │ ∆ assets/dexopt/baseline.prof 4 MiB │ +1.1 KiB │ 8.7 MiB │ +856 B │ ∆ classes.dex 52.9 KiB │ +7 B │ 117.2 KiB │ 0 B │ ∆ META-INF/CERT.SF 49.6 KiB │ -5 B │ 117.1 KiB │ 0 B │ ∆ META-INF/MANIFEST.MF 1.2 KiB │ +2 B │ 1.2 KiB │ 0 B │ ∆ META-INF/CERT.RSA ──────────┼──────────┼───────────┼──────────┼─────────────────────────────── 4.1 MiB │ +2.5 KiB │ 9 MiB │ +2.2 KiB │ (total) ```
DEX ``` STRINGS: old │ new │ diff ───────┼───────┼──────────── 43585 │ 43586 │ +1 (+4 -3) + Lg7/n; + X2 + [LW4/g; + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c6ab9a4,r8-mode:full,version:8.3.37} - LW4/l; - [LW4/h; - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c35a707,r8-mode:full,version:8.3.37} TYPES: old │ new │ diff ───────┼───────┼─────────── 14988 │ 14988 │ 0 (+2 -2) + Lg7/n; + [LW4/g; - LW4/l; - [LW4/h; METHODS: old │ new │ diff ───────┼───────┼──────────────── 62032 │ 62034 │ +2 (+203 -201) + A4.c B1() → Map + A4.d B1() → Map + A4.e B1() → Map + A4.f B1() → Map + A4.g B1() → Map + D.f A0(int, int) → long + D.f A1(h, i) → h + D.f A2(E0) → R1 + D.f B0(F, n, k, int) + D.f B1() → Map + D.f B2(String) → String + D.f C0(boolean, h, List, boolean, boolean, int, boolean, boolean, q, c, k, int, int) + D.f C1(Drawable) → ColorStateList + D.f C2(long, long) → long + D.f D0(H0, q, k, int, int) + D.f D1(Context, String, boolean, boolean, boolean) → String + D.f D2(E0) + D.f E0(boolean, a, a, k, int) + D.f E1(Context, int) → Drawable + D.f E2(String, String) + D.f F0(k, int) + D.f F1(double) → long + D.f F2(String, String, Throwable) + D.f G0(g, c, boolean, k, int) + D.f G1(Context, int) → float + D.f G2(j, Object, Object, e, e) → Object + D.f H0(a, a, e, i2, k, int) + D.f H1(j) → c0 + D.f I0(i2, q, k, int, int) + D.f I1(String[], int) → float + D.f J0(e0, k, int) + D.f J1(b) → b + D.f K0(String, long, D, boolean, boolean, boolean, k, int) + D.f K1(double) → long + D.f L0(p0, float, boolean, boolean, boolean, a, c, c, c, q, k, int, int) + D.f L1(int) → long + D.f M0(a, e, k, int) + D.f M1(Object[]) → int + D.f N0(String, String, c, c, k, int) + D.f N1(View) + D.f O0(b, v, I, c, c0, e) → Serializable + D.f O1(j) → boolean + D.f P0(b, z, long, c, g, boolean, c0, e) → Object + D.f P1(String) → boolean + D.f Q0(Context) → C + D.f Q1() → boolean + D.f R0(O2) → O2 + D.f R1(View) → boolean + D.f S(m0, boolean, k, int) + D.f S0(c, z) + D.f S1(String, String) → boolean + D.f T(int, k, String) + D.f T0(b, boolean) → int + D.f T1(int, String) → boolean + D.f U(String, boolean, q, c, boolean, boolean, e0, d0, e, P, e, e, e, k, int, int, int) + D.f U0(float[]) → float + D.f U1(long) → boolean + D.f V(int, k, q, String) + D.f V0(m, b, e) → Object + D.f V1(Context) → boolean + D.f W(float, boolean, boolean, c, q, k, int, int) + D.f W0(m, K, e) → Object + D.f W1(Object[]) → n + D.f X(String, q, boolean, k, int, int) + D.f X0(Context, Looper, d, b, h, i) → g + D.f X1(w, String) → w + D.f Y(q, k, int) + D.f Y0(q, i, List) → boolean + D.f Y1(e) → k + D.f Z(o, c, c, a, a, c, k, int) + D.f Z0(boolean) + D.f Z1(Configuration, Typeface) → Typeface + D.f a0(E, e, List, e, c, a, c, a, v, k, int) + D.f a1(long) + D.f a2(h, i) → j + D.f b0(k, int) + D.f b1(a) → W + D.f b2(b, c0, long, C, e) → Object + D.f c0(float, boolean, boolean, c, q, k, int, int) + D.f c1(SecretKeySpec, byte[], Provider) → byte[] + D.f c2(float, long) → long + D.f d0(boolean, boolean, q, int, k, int, int) + D.f d1(View, ConstraintLayout) + D.f d2(JSONObject) → P0 + D.f e0(b) → d + D.f e1(E) → o + D.f e2(x0) + D.f f0(boolean, e, C, a, a, c, k, int) + D.f f1(int, int) + D.f f2(int, PorterDuff_Mode) → PorterDuff_Mode + D.f g0() → C + D.f g1(H, w) → b + D.f g2(h, j) → j + D.f h0(String, q, long, long, z, D, s, long, m, l, long, boolean, c, D, char, int, k, int, int, int) + D.f h1(Drawable, ColorStateList, PorterDuff_Mode) → Drawable + D.f h2(float[], float[], int, float[]) + D.f i0(h, q, P, float, long, long, long, e, k, int, int) + D.f i1(String, String) + D.f i2(Q[], k) → C + D.f j0(e, a, a, k, int) + D.f j1() + D.f j2(float, long, long, k, int) → e + D.f k0(l, k, int) + D.f k1(float[], float[]) → float + D.f k2(Context, int, int) → int + D.f l0(List, int, boolean, c, y, q, E, k, int, int) + D.f l1(q, S, c0, boolean, m, boolean, f, boolean) → q + D.f l2(Context, int, Interpolator) → TimeInterpolator + D.f m0(List, int, boolean, y, q, k, int, int) + D.f m1(g, long, long, float) + D.f m2(View, H) + D.f n0(boolean, k, int) + D.f n1(Str ...✂ ```