search

stripe / stripe-android

Stripe Android SDK
https://stripe.com/docs/mobile/android
MIT License
1.29k stars 648 forks source link

Remove basic integration code #9501

Closed amk-stripe closed 3 weeks ago

amk-stripe commented 3 weeks ago

Summary

Remove Basic Integration code

API review: https://jira.corp.stripe.com/browse/MOBILE_APIREVIEW-104

Motivation

Deprecating Basic Integration! https://jira.corp.stripe.com/browse/MOBILESDK-2465

Testing

CI checks ensure everything besides BI is still working. Manually verified that everything we want to delete is deleted.

Changelog

Basic Integration

github-actions[bot] commented 3 weeks ago

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed           
          ├───────────┬───────────┬───────────┼───────────┬─────────┬────────────
 APK      │ old       │ new       │ diff      │ old       │ new     │ diff       
──────────┼───────────┼───────────┼───────────┼───────────┼─────────┼────────────
      dex │   4.1 MiB │     4 MiB │ -57.1 KiB │   8.9 MiB │ 8.7 MiB │ -117.4 KiB 
     arsc │   2.3 MiB │   2.3 MiB │    -332 B │   2.3 MiB │ 2.3 MiB │     -332 B 
 manifest │   5.1 KiB │     5 KiB │     -76 B │  25.6 KiB │  25 KiB │     -656 B 
      res │ 933.7 KiB │ 932.6 KiB │  -1.2 KiB │   1.5 MiB │ 1.5 MiB │   -2.3 KiB 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │   6 MiB │        0 B 
    asset │   2.9 MiB │   2.9 MiB │     +46 B │   2.9 MiB │ 2.9 MiB │      +46 B 
    other │ 201.3 KiB │ 201.2 KiB │    -148 B │ 443.4 KiB │ 443 KiB │     -328 B 
──────────┼───────────┼───────────┼───────────┼───────────┼─────────┼────────────
    total │    13 MiB │    13 MiB │ -58.8 KiB │  22.1 MiB │  22 MiB │   -121 KiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 43009 │ 42294 │ -715 (+4818 -5533)   
   types │ 14524 │ 14392 │ -132 (+4813 -4945)   
 classes │ 12110 │ 12003 │ -107 (+3968 -4075)   
 methods │ 62494 │ 61977 │ -517 (+33487 -34004) 
  fields │ 41088 │ 40651 │ -437 (+24732 -25169) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6274 │ 6269 │ -5 (+0 -5)
APK ``` compressed │ uncompressed │ ──────────┬───────────┼───────────┬────────────┤ size │ diff │ size │ diff │ path ──────────┼───────────┼───────────┼────────────┼──────────────────────────────── 4 MiB │ -57.1 KiB │ 8.7 MiB │ -117.4 KiB │ ∆ classes.dex │ -836 B │ │ -1.8 KiB │ - res/So.xml │ -354 B │ │ -504 B │ - res/rJ.xml 2.3 MiB │ -332 B │ 2.3 MiB │ -332 B │ ∆ resources.arsc 127 B │ +127 B │ 5 B │ +5 B │ + META-INF/services/T9.A 127 B │ +127 B │ 5 B │ +5 B │ + META-INF/services/U9.a │ -127 B │ │ -5 B │ - META-INF/services/V9.A │ -127 B │ │ -5 B │ - META-INF/services/W9.a 53.6 KiB │ -81 B │ 119 KiB │ -164 B │ ∆ META-INF/CERT.SF 5 KiB │ -76 B │ 25 KiB │ -656 B │ ∆ AndroidManifest.xml 50.4 KiB │ -67 B │ 118.9 KiB │ -164 B │ ∆ META-INF/MANIFEST.MF 8.2 KiB │ +57 B │ 8 KiB │ +57 B │ ∆ assets/dexopt/baseline.prof 1 KiB │ -11 B │ 932 B │ -11 B │ ∆ assets/dexopt/baseline.profm 1.1 KiB │ +4 B │ 3.2 KiB │ 0 B │ ∆ res/B7.xml 961 B │ -3 B │ 2.7 KiB │ 0 B │ ∆ res/ZW.xml 950 B │ -3 B │ 2.5 KiB │ 0 B │ ∆ res/de.xml 546 B │ +2 B │ 952 B │ 0 B │ ∆ res/zR.xml 812 B │ +1 B │ 2.3 KiB │ 0 B │ ∆ res/1w.xml 908 B │ +1 B │ 2 KiB │ 0 B │ ∆ res/2j.xml 749 B │ -1 B │ 1.5 KiB │ 0 B │ ∆ res/3O.xml 465 B │ +1 B │ 656 B │ 0 B │ ∆ res/5l.xml 849 B │ -1 B │ 1.8 KiB │ 0 B │ ∆ res/8Q.xml 743 B │ +1 B │ 1.5 KiB │ 0 B │ ∆ res/9V.xml 764 B │ +1 B │ 1.6 KiB │ 0 B │ ∆ res/A0.xml 1.1 KiB │ +1 B │ 3.4 KiB │ 0 B │ ∆ res/B4.xml 437 B │ -1 B │ 708 B │ 0 B │ ∆ res/CP.xml 717 B │ -1 B │ 1.5 KiB │ 0 B │ ∆ res/FR.xml 348 B │ +1 B │ 496 B │ 0 B │ ∆ res/KX.xml 518 B │ -1 B │ 1 KiB │ 0 B │ ∆ res/Lx.xml 877 B │ -1 B │ 2.3 KiB │ 0 B │ ∆ res/YB.xml 542 B │ +1 B │ 1.1 KiB │ 0 B │ ∆ res/ZM.xml 705 B │ +1 B │ 1.5 KiB │ 0 B │ ∆ res/a1.xml 365 B │ -1 B │ 472 B │ 0 B │ ∆ res/aA.xml 756 B │ +1 B │ 1.7 KiB │ 0 B │ ∆ res/cZ.xml 1.2 KiB │ +1 B │ 3.4 KiB │ 0 B │ ∆ res/dO.xml 809 B │ +1 B │ 1.8 KiB │ 0 B │ ∆ res/eA.xml 395 B │ -1 B │ 528 B │ 0 B │ ∆ res/f6.xml 490 B │ +1 B │ 892 B │ 0 B │ ∆ res/fY.xml 445 B │ +1 B │ 816 B │ 0 B │ ∆ res/fg.xml 655 B │ +1 B │ 1.5 KiB │ 0 B │ ∆ res/fu.xml 683 B │ +1 B │ 1.5 KiB │ 0 B │ ∆ res/hP1.xml 672 B │ +1 B │ 1.5 KiB │ 0 B │ ∆ res/jA.xml 505 B │ -1 B │ 984 B │ 0 B │ ∆ res/mU.xml 1.1 KiB │ -1 B │ 3.2 KiB │ 0 B │ ∆ res/nn.xml 632 B │ -1 B │ 1.1 KiB │ 0 B │ ∆ res/oD.xml 753 B │ -1 B │ 1.7 KiB │ 0 B │ ∆ res/p0.xml 443 B │ -1 B │ 752 B │ 0 B │ ∆ res/r6.xml 532 B │ -1 B │ 1.3 KiB │ 0 B │ ∆ res/sl.xml 691 B │ -1 B │ 1.4 KiB │ 0 B │ ∆ res/vG.xml 635 B │ +1 B │ 1,020 B │ 0 B │ ∆ res/vq.xml 465 B │ -1 B │ 728 B │ 0 B │ ∆ res/zE.xml 535 B │ -1 B │ 952 B │ 0 ...✂ ```
MANIFEST ``` @@ -255,17 +255,2 @@ android:exported="false" - android:name="com.stripe.android.view.AddPaymentMethodActivity" - android:theme="@style/StripeDefaultTheme" - /> - - -
DEX ``` STRINGS: old │ new │ diff ───────┼───────┼──────────────────── 43009 │ 42294 │ -715 (+4818 -5533) + ILIIIZ + LA5/A; + LA5/B; + LA5/C; + LA5/D; + LA5/E; + LA5/F; + LA5/G; + LA5/H; + LA5/I; + LA5/J; + LA5/K; + LA5/L; + LA5/M; + LA5/N; + LA5/O; + LA5/P; + LA5/Q; + LA5/S; + LA5/T; + LA5/U; + LA5/V; + LA5/W; + LA5/X; + LA5/Y; + LA5/Z; + LA5/a0; + LA5/b0; + LA5/c0; + LA5/c; + LA5/d0; + LA5/d; + LA5/e; + LA5/f; + LA5/g; + LA5/h; + LA5/i; + LA5/j; + LA5/k; + LA5/l; + LA5/m; + LA5/n; + LA5/o; + LA5/p; + LA5/q; + LA5/r; + LA5/s; + LA5/t; + LA5/u; + LA5/v; + LA5/w; + LA5/x; + LA5/y; + LA5/z; + LA6/A; + LA6/B; + LA6/C; + LA6/D; + LA6/E; + LA6/F; + LA6/G; + LA6/H; + LA6/I; + LA6/J; + LA6/K; + LA6/L; + LA6/M; + LA6/N; + LA6/e; + LA6/f; + LA6/g; + LA6/h; + LA6/i; + LA6/j; + LA6/k; + LA6/l; + LA6/m; + LA6/n; + LA6/o; + LA6/p; + LA6/q; + LA6/r; + LA6/s; + LA6/t; + LA6/u; + LA6/v; + LA6/w; + LA6/x; + LA6/y; + LA6/z; + LB8/g; + LB8/h; + LB8/i; + LB8/j; + LB8/k; + LB8/l; + LB8/m; + LB8/n; + LB8/o; + LBa/a; + LC2/c; + LC2/d; + LC2/e; + LC2/f; + LC2/g; + LC2/h; + LC2/i; + LC2/j; + LC2/k; + LC2/l; + LC2/m; + LC2/n; + LC2/o; + LC3/a; + LC3/b; + LC7/c; + LC7/d; + LC7/e; + LC7/f; + LC7/g; + LC7/h; + LC7/i; + LC7/j; + LC7/k; + LC8/a; + LC8/b; + LC8/c; + LC8/d; + LC8/e; + LC8/f; + LC8/g; + LC8/h; + LC8/i; + LC8/j; + LC8/k; + LC8/l; + LC8/m; + LC8/n; + LC8/o; + LC8/p; + LC8/q; + LC8/r; + LC8/s; + LC8/t; + LC8/u; + LC8/v; + LC8/w; + LC8/x; + LCa/a; + LD/e; + LD3/h; + LD3/i; + LD3/j; + LD3/k; + LD3/l; + LD3/m; + LD3/n; + LD3/o; + LD3/p; + LD3/q; + LD3/r; + LD3/s; + LD3/t; + LD4/b; + LD4/c; + LD4/d; + LD4/e; + LD4/f; + LD6/A; + LD6/B; + LD6/C; + LD6/D; + LD6/E; + LD6/F; + LD6/G; + LD6/H; + LD6/I; + LD6/d; + LD6/e; + LD6/f; + LD6/g; + LD6/h; + LD6/i; + LD6/j; + LD6/k; + LD6/l; + LD6/m; + LD6/n; + LD6/o; + LD6/p; + LD6/q; + LD6/r; + LD6/s; + LD6/t; + LD6/u; + LD6/v; + LD6/w; + LD6/x; + LD6/y; + LD6/z; + LE2/b; + LE2/c; + LE2/d; + LE2/e; + LE2/f; + LE2/g; + LE2/h; + LE2/i; + LE5/e; + LE5/f; + LE5/g; + LE5/h; + LE5/i; + LE5/j; + LE5/k; + LE7/A; + LE7/B; + LE7/C; + LE7/D; + LE7/E; + LE7/F; + LE7/G; + LE7/H; + LE7/I; + LE7/J; + LE7/K; + LE7/L; + LE7/M; + LE7/N; + LE7/O; + LE7/P; + LE7/Q; + LE7/S; + LE7/T; + LE7/U; + LE7/V; + LE7/W; + LE7/X; + LE7/Y; + LE7/Z; + LE7/a0; + LE7/b0; + LE7/c0; + LE7/d0; + LE7/e0; + LE7/f0; + LE7/g0; + LE7/h0; + LE7/i0; + LE7/j0; + LE7/k0; + LE7/l; + LE7/m; + LE7/n; + LE7/o; + LE7/p; + LE7/q; + LE7/r; + LE7/s; + LE7/t; + LE7/u; + LE7/v; + LE7/w; + LE7/x; + LE7/y; + LE7/z; + LF5/A0; + LF5/A; + LF5/B0; + LF5/B; + LF5/C0; + LF5/C; + LF5/D0; + LF5/D; + LF5/E0; + LF5/E; + LF5/F0; + LF5/F; + LF5/G0; + LF5/G; + LF5/H0; + LF5/H; + LF5/I0; + LF5/I; + LF5/J0; + LF5/J; + LF5/K0; + LF5/K; + LF5/L0; + LF5/L; + LF5/M0; + LF5/M; + LF5/N0; + LF5/N; + LF5/O0; + LF5/O; + LF5/P0; + LF5/P; + LF5/Q0; + LF5/Q; + LF5/R0; + LF5/S0; + LF5/S; + LF5/T0; + LF5/T; + LF5/U0; + LF5/U; + LF5/V0; + LF5/V; + LF5/W0; + LF5/W; + LF5/X0; + LF5/X; + LF5/Y0; + LF5/Y; + LF5/Z0; + LF5/Z; + LF5/a0; + LF5/a1; + LF5/b0; + LF5/b1; + LF5/b; + LF5/c0; + LF5/c1; + LF5/c; + LF5/d0; + LF5/d1; + LF5/d; + LF5/e0; + LF5/e1; + LF5/e; + LF5/f0; + LF5/f1; + LF5/f; + LF5/g0; + LF5/g1; + LF5/g; + LF5/h0; + LF5/h1; + LF5/h; + LF5/i0; + LF5/i1; + LF5/i; + LF5/j0; + LF5/j1; + LF5/j; + LF5/k0; + LF5/k1; + LF5/k; + LF5/l0; + LF5/l1; + LF5/l; + LF5/m0; + LF5/m1; + LF5/m; + LF5/n0; + LF5/n1; + LF5/n; + LF5/o0; + LF5/o1; + LF5/o; + LF5/p0; + LF5/p1; + LF5/p; + LF5/q0; + LF5/q1; + LF5/q; + LF5/r0; + LF5/r1; + LF5/r; + LF5/s0; + LF5/s1; + LF5/s; + LF5/t0; + LF5/t; + LF5/u0; + LF5/u; + LF5/v0; + LF5/v; + LF5/w0; + LF5/w; + LF5/x0; + LF5/x; + LF5/y0; + LF5/y; + LF5/z0; + LF5/z; + LF7/b; + LF7/c; + LF ...✂ ```
ARSC ``` ENTRIES: old │ new │ diff ──────┼──────┼──────────── 6274 │ 6269 │ -5 (+0 -5) - id/footer_container - id/recycler - id/shipping_flow_viewpager - layout/stripe_payment_flow_activity - layout/stripe_payment_methods_activity ```